Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket-getpeername.xml: remove excessive length of refpurpose #3497

Merged
merged 1 commit into from
Jul 7, 2024
Merged

socket-getpeername.xml: remove excessive length of refpurpose #3497

merged 1 commit into from
Jul 7, 2024

Conversation

mmalferov
Copy link
Member

@mmalferov mmalferov commented Jun 27, 2024 •
edited
Loading

Or at least no longer than that, as example: Queries the remote side of the given socket for a host/port or a file system path

@mmalferov
socket-getpeername.xml: remove excessive length of refpurpose
53653df 
Or at least no longer than that, as example: `Queries the remote side of the given socket for a host/port or a  file system path`
@mmalferov
Copy link
Member Author

Maybe or: Polls the remote side of the given socket (I don't have enough sense of English to shorten the title but keep the meaning)

Girgias
Girgias approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds sensible to me, maybe @devnexen wants to have another look at it?

@devnexen devnexen merged commit 5eaa345 into php:master Jul 7, 2024
2 checks passed
@mmalferov mmalferov deleted the patch-20 branch July 7, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalferov @devnexen @Girgias